Skip to content

Adding initial version of Cirro validation to CI/CD#276

Merged
tefirman merged 3 commits intomainfrom
add-cirro-linting
Mar 17, 2026
Merged

Adding initial version of Cirro validation to CI/CD#276
tefirman merged 3 commits intomainfrom
add-cirro-linting

Conversation

@tefirman
Copy link
Member

@tefirman tefirman commented Mar 13, 2026

Type of Change

  • Other: CI/CD enhancement

Description

Adds basic validation of Cirro platform configurations (.cirro/ directories) to the CI/CD linting pipeline. The validation script checks pipelines that have .cirro/ subdirectories and skips those that don't. For each .cirro/ directory it verifies:

  • All 5 required files are present (preprocess.py, process-form.json, process-input.json, process-output.json, process-compute.config)
  • JSON files parse without errors
  • process-form.json has the expected form.properties structure
  • process-input.json values are valid JSON path mappings ($. prefixed)
  • preprocess.py has no Python syntax errors

Testing

How did you test these changes?
Ran make lint_cirro locally, which validated all 6 pipelines with .cirro/ configurations and correctly skipped the 5 without.

Did the tests pass?
Yes — all 6 existing Cirro configurations passed validation.

Documentation

  • I updated the README (if applicable)
  • I added/updated parameter descriptions in the WDL (if applicable)
  • I ran make docs-preview to check documentation rendering (if applicable)

Additional Context

  • The cirro_validation job runs in parallel with the existing linting jobs in the linting.yml workflow.
  • A new make lint_cirro target is available for local use and is included in the make lint meta-target.

@tefirman tefirman marked this pull request as ready for review March 13, 2026 06:44
@tefirman tefirman requested a review from emjbishop as a code owner March 13, 2026 06:44
Copy link
Collaborator

@emjbishop emjbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be so nice to have! Seems like it covers everything we reasonably can

@tefirman tefirman merged commit 9e284c4 into main Mar 17, 2026
8 checks passed
@tefirman tefirman deleted the add-cirro-linting branch March 17, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants