Adding initial version of Cirro validation to CI/CD#276
Merged
Conversation
emjbishop
approved these changes
Mar 17, 2026
Collaborator
emjbishop
left a comment
There was a problem hiding this comment.
This will be so nice to have! Seems like it covers everything we reasonably can
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds basic validation of Cirro platform configurations (
.cirro/directories) to the CI/CD linting pipeline. The validation script checks pipelines that have.cirro/subdirectories and skips those that don't. For each.cirro/directory it verifies:preprocess.py,process-form.json,process-input.json,process-output.json,process-compute.config)process-form.jsonhas the expectedform.propertiesstructureprocess-input.jsonvalues are valid JSON path mappings ($.prefixed)preprocess.pyhas no Python syntax errorsTesting
How did you test these changes?
Ran
make lint_cirrolocally, which validated all 6 pipelines with.cirro/configurations and correctly skipped the 5 without.Did the tests pass?
Yes — all 6 existing Cirro configurations passed validation.
Documentation
I added/updated parameter descriptions in the WDL (if applicable)I ranmake docs-previewto check documentation rendering (if applicable)Additional Context
cirro_validationjob runs in parallel with the existing linting jobs in thelinting.ymlworkflow.make lint_cirrotarget is available for local use and is included in themake lintmeta-target.